Bug: Mismatched build argument in WebUI Dockerfile prevents API URL configuration #451
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've found a small bug in the
Dockerfile_WebUIthat prevents configuring the backend API URL at build time. It seems to be caused by a simple variable name mismatch.The Vue.js application code expects an environment variable named
VUE_APP_RESTAPI_URL:However, the
Dockerfile_WebUIdeclares and sets a build argument with a different name,VUE_APP_API_URL(it's missing "REST"):Because the names don't match, any value passed as a
build-argis ignored by the application, and it always uses its internal fallback URL (http://127.0.0.1:8443/api).A simple fix would be to align the variable name in
Dockerfile_WebUIto match what the application code expects.Hope this helps! Thanks for the great work on the project.