Skip to content

Make behavior of pack filtering consistent in case of all packs enabled (#1411)#2357

Merged
edriouk merged 1 commit intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/PackFilterAll
Feb 6, 2026
Merged

Make behavior of pack filtering consistent in case of all packs enabled (#1411)#2357
edriouk merged 1 commit intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/PackFilterAll

Conversation

@grasci-arm
Copy link
Collaborator

  • Make behavior of pack filtering consistent in case of all packs enabled

Filter to use all latest packs also includes all explicitly selected
Required by RPC and is consistent with csolution processing

  • Update tools/projmgr/test/src/ProjMgrRpcTests.cpp

Co-authored-by: Daniel Brondani daniel.brondani@arm.com

  • Copyright and format

Co-authored-by: Daniel Brondani daniel.brondani@arm.com

…ed (Open-CMSIS-Pack#1411)

* Make behavior of pack filtering consistent in case of all packs enabled

Filter to use all latest packs also includes all explicitly selected
Required by RPC and is consistent with csolution processing

* Update tools/projmgr/test/src/ProjMgrRpcTests.cpp

Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>

* Copyright and format

---------

Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results

  7 files   53 suites   4m 49s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 1551f5f.

♻️ This comment has been updated with latest results.

@edriouk edriouk merged commit cc68f07 into Open-CMSIS-Pack:main Feb 6, 2026
84 checks passed
@edriouk edriouk deleted the outbound/PackFilterAll branch February 6, 2026 18:02
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.47%. Comparing base (7c8af37) to head (1551f5f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2357   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         145      145           
  Lines       26013    26013           
  Branches    15674    15674           
=======================================
+ Hits        16771    16772    +1     
  Misses       7081     7081           
+ Partials     2161     2160    -1     
Flag Coverage Δ
buildmgr-cov 79.87% <ø> (ø)
packchk-cov 69.48% <ø> (ø)
projmgr-cov 87.40% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 88.06% <100.00%> (+<0.01%) ⬆️
tools/projmgr/src/ProjMgrRpcServer.cpp 83.45% <83.33%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants