feat: add removeAllClickListeners method to avoid keeping instances of all click listeners#1118
Open
ipapps wants to merge 1 commit intoOneSignal:mainfrom
Open
feat: add removeAllClickListeners method to avoid keeping instances of all click listeners#1118ipapps wants to merge 1 commit intoOneSignal:mainfrom
ipapps wants to merge 1 commit intoOneSignal:mainfrom
Conversation
Collaborator
|
Thanks for the pr, seems like a useful feature. |
Collaborator
|
I'll need to chat with other team members if it's something we want for all the wrapper sdks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add removeAllClickListeners method to avoid keeping instances of all click listeners
Details
Motivation
It is quite cumbersome to keep instances of all click listeners. Most of the time we have one, but need a simple way to remove it. By clearing all, it does the job just fine. Also, in state management, it prevents recreating click listeners when initializing method are fired multiple times.
Scope
Notification click listeners
Manual testing
Tested on my apps without any problem
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is