Open
Conversation
2d5c9a6 to
55bd06e
Compare
1 task
996291b to
dc61d1b
Compare
dc61d1b to
8e86c1b
Compare
8e86c1b to
755b480
Compare
sherwinski
requested changes
Jan 7, 2026
4090cbb to
763875f
Compare
nan-li
requested changes
Jan 7, 2026
Contributor
nan-li
left a comment
There was a problem hiding this comment.
- Duplicate source files in
ios/Classes/andios/onesignal_flutter/Sources/onesignal_flutter/. Step 8 and 9 of guide notes to remove old directory:
Move all files from ios/Classes to ios/plugin_name/Sources/plugin_name.
The ios/Assets, ios/Resources, and ios/Classes directories should now be empty and can be deleted.
- Info on documentation steps needed? This is the existing Flutter SDK setup: https://documentation.onesignal.com/docs/en/flutter-sdk-setup. Can you add any notes on how we would update the docs?
nan-li
reviewed
Jan 7, 2026
75bac60 to
6d44027
Compare
6d44027 to
e3d723c
Compare
26bf451 to
3fc7238
Compare
Collaborator
Author
|
Seems like for NSE and live activity widget they both need to manually add OneSignalXCFramework to "Frameworks and Libraries" section |
|
Any updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds swift package manager support for the flutter sdk package.
Details
Closes #971
Follows https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager guide for setting up spm for flutter plugins.
Motivation
Testing
Manual testing
Test step 20 for https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager
where I disabled spm config and did
flutter runin the example projectThen I re-enabled spm config and did the same thing and it still worked.
Pods:
Show pod install

SPM:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is