Skip to content

Shravya_Kudlu/bugfix/css-module.css-#3829#3921

Merged
one-community merged 12 commits intodevelopmentfrom
shravya_bugfix/css-modules-#3829
Feb 9, 2026
Merged

Shravya_Kudlu/bugfix/css-module.css-#3829#3921
one-community merged 12 commits intodevelopmentfrom
shravya_bugfix/css-modules-#3829

Conversation

@ShravyaKudlu
Copy link
Contributor

@ShravyaKudlu ShravyaKudlu commented Aug 19, 2025

Description

Fixes # (Bug from #3829)

Related PRS (if any):

This frontend PR is related to the development backend branch

Main changes explained:

  • Delete css file
  • Create module.css and follow the convention

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to path /pr-team-analytics/reviewers-stacked-bar-chart
  6. click on duration -> all and verify its shown in dark and light mode

Screenshots or videos of changes:

Screenshot from 2025-08-19 15-42-18 Screenshot from 2025-08-19 20-31-34

Note

@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 79b36fe
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/698811a8c19ae10008b94492
😎 Deploy Preview https://deploy-preview-3921--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShravyaKudlu ShravyaKudlu changed the title WIP: Refactor of jsx and css WIP: Shravya_Kudlu/bugfix/css-module.css-#3829 Aug 19, 2025
@ShravyaKudlu ShravyaKudlu changed the title WIP: Shravya_Kudlu/bugfix/css-module.css-#3829 Shravya_Kudlu/bugfix/css-module.css-#3829 Aug 20, 2025
@ShravyaKudlu ShravyaKudlu marked this pull request as ready for review August 20, 2025 00:33
@ShravyaKudlu ShravyaKudlu requested a review from Copilot August 20, 2025 01:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts a CSS component to use CSS modules following project conventions. The main changes involve deleting a regular CSS file and creating a module.css file with proper naming conventions, while also adding a new route for a PR reviewers analytics component.

  • Refactored CSS to use CSS modules pattern with scoped class names
  • Added new route for ReviewersStackedBarChart component
  • Created mock data file for the reviewers component

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/routes.jsx Added new protected route for reviewers stacked bar chart component
src/components/HGNPRDashboard/ReviewersStackedBarChart/reviewersMockData.js New mock data file containing reviewer analytics test data
src/components/HGNPRDashboard/ReviewersStackedBarChart/ReviewersStackedBarChart.module.css CSS module file with scoped styles for the chart component
src/components/HGNPRDashboard/ReviewersStackedBarChart/ReviewersStackedBarChart.jsx Main React component for displaying reviewer analytics in a stacked bar chart

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

return (
<div
className={`${styles.reviewersChartContainer} ${darkMode ? styles.darkMode : ''}`}
style={{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a consistent background color, I used this inline style. Since I couldn't find a way to import our darkTheme color within this route, I'm not sure if this is the best approach. Could you please review and let me know if there's a better way to handle this?

@ShravyaKudlu ShravyaKudlu added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Aug 26, 2025
aseemdeshmukh
aseemdeshmukh previously approved these changes Aug 28, 2025
Copy link
Contributor

@aseemdeshmukh aseemdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works perfect in both light and dark mode!
PR3921_1
PR3921_2

Copy link

@sohamsharma08 sohamsharma08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR successfully. The PR Quality Chart works well with dark mode as expected. Screenshots are attached below:

PR 3921 (1) PR 3921 (2) PR 3921 (3)

Copy link

@munishpatel munishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Team Analytics stacked bar chart screen works properly in both light and dark mode:
Screenshot 2025-09-12 at 5 32 15 PM
Screenshot 2025-09-12 at 5 32 23 PM

RitzzzZ2021
RitzzzZ2021 previously approved these changes Sep 13, 2025
Copy link
Contributor

@RitzzzZ2021 RitzzzZ2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stacked bar chart looks great in both light mode and dark mode. Great work!

image image

somramnani
somramnani previously approved these changes Sep 18, 2025
Copy link

@somramnani somramnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR as an admin user following the provided steps. The stacked bar chart renders correctly in both light and dark mode.

Additional checks:

  • Verified the Teams category across All, Alpha, Beta, Delta, and Gamma are all displayed as expected.

  • Confirmed that Ascending/Descending sorting works correctly.

Light Mode
Screenshot 2025-09-18 at 4 03 43 PM

Dark Mode
Screenshot 2025-09-18 at 4 04 09 PM

@beblicarl
Copy link
Contributor

This feature works as intended on both light and dark screens

image image

@beblicarl beblicarl self-requested a review September 19, 2025 15:15
beblicarl
beblicarl previously approved these changes Sep 19, 2025
abhirambj
abhirambj previously approved these changes Sep 20, 2025
Copy link

@abhirambj abhirambj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the Reviewers Stacked Bar Chart on /pr-team-analytics/reviewers-stacked-bar-chart. All legacy CSS has been properly migrated to CSS modules, classNames are scoped, and there are no inline or global styles left. UI renders as expected with all filters and chart features working correctly in both dark and light modes.

No regressions, and the code is now much cleaner and more maintainable.

PR #3921 - Light Mode PR #3921 - Dark Mode

aryanrachala54
aryanrachala54 previously approved these changes Sep 21, 2025
Copy link
Contributor

@aryanrachala54 aryanrachala54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the changes and tested the /pr-team-analytics/reviewers-stacked-bar-chart route. The chart displays correctly when the duration is set to "All Time", but selecting other options like "Last Week", "Last 2 Weeks", or "Last Month" results in a "No PR data available" message, and no chart is shown.

Aside from this, everything else functions as expected such as filters, sorting, and team categories render correctly. The use of scoped styles and the transition to module.css significantly improve code clarity and maintainability.

Screenshot 2025-09-20 221006 Screenshot 2025-09-20 221034 Screenshot 2025-09-20 221021 Screenshot 2025-09-20 221016

deep3072
deep3072 previously approved these changes Sep 21, 2025
Copy link
Contributor

@deep3072 deep3072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the css bug fix changes of PR Quality reviewers chart. It works fine in both dark mode and light mode. Also the functions like Ascending and Descending works well along with the the team filters. Approve.

Screenshot 2025-09-20 at 23 01 15 Screenshot 2025-09-20 at 23 01 28

@ShravyaKudlu ShravyaKudlu force-pushed the shravya_bugfix/css-modules-#3829 branch 2 times, most recently from 2d9b1b2 to f1d942f Compare October 25, 2025 22:14
@sonarqubecloud
Copy link

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shravya,

Good job with this implementation, however, there's only data for "all time" duration.

PR 3921 Screenshot PR 3921 Screenshot 2

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shravya,

I have reviewed your PR locally and it does work as per requirement. Though i would like to point out that the dropdown filters are in light mode which might get pointed out. Also the page does not support mobile responsiveness.

Screenshot 2026-01-19 at 8 01 55 PM Screenshot 2026-01-19 at 8 02 03 PM Screenshot 2026-01-19 at 8 02 09 PM Screenshot 2026-01-19 at 8 02 21 PM Screenshot 2026-01-19 at 8 02 56 PM Screenshot 2026-01-19 at 8 04 41 PM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@ShravyaKudlu
Copy link
Contributor Author

Fixed responisive mentioned in the comments, and the filter in darkmode

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit f888bc7 into development Feb 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments