[Podspec] remove version for FBSDK#30
Open
markedwardmurray wants to merge 3 commits intoOceanLabs:masterfrom
Open
[Podspec] remove version for FBSDK#30markedwardmurray wants to merge 3 commits intoOceanLabs:masterfrom
markedwardmurray wants to merge 3 commits intoOceanLabs:masterfrom
Conversation
|
👍 |
|
👍 Looks good for v4.13.0 as well |
Author
|
(sorry for the notification spam for anyone following, I had an issue with FB Login that I had to diagnose) |
|
An important pull request! 👍 |
Author
|
hey @anatha if you haven't already point your Podfile to install from this fork (or your own) so you can move forward with 4.13.1 |
|
Wasn't aware that this was an option - thanks @markedwardmurray! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys!
Great library, thank you for sharing it. We've been using it in www.getsquad.co and realized the FBSDK dependency is a version behind. It seems to run fine for our purposes on 4.12.0
Cheers!
~Mark