Skip to content

BVEL[G|O|W][I|J|K][|-] summary keywords#6830

Open
daavid00 wants to merge 2 commits intoOPM:masterfrom
daavid00:bvels
Open

BVEL[G|O|W][I|J|K][|-] summary keywords#6830
daavid00 wants to merge 2 commits intoOPM:masterfrom
daavid00:bvels

Conversation

@daavid00
Copy link
Member

@daavid00 daavid00 commented Feb 13, 2026

Depends on OPM/opm-common#4989

Before merging, in order to add to the test the implementation, updating the data in OPM/opm-tests#1492

@daavid00 daavid00 added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Feb 13, 2026
if (summaryConfig.keywords("BVEL*").size() > 0) {
const std::array<int, 3> phaseIdxs { gasPhaseIdx, oilPhaseIdx, waterPhaseIdx };
const std::array<int, 3> compIdxs { gasCompIdx, oilCompIdx, waterCompIdx };
const std::string nameIdxs[3] { "G", "O", "W" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why suddenly 2 C arrays?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I have updated the PR, thanks :).

@daavid00 daavid00 marked this pull request as draft February 13, 2026 15:14
@daavid00 daavid00 marked this pull request as ready for review February 13, 2026 17:06
@daavid00 daavid00 marked this pull request as draft February 14, 2026 10:47
@daavid00
Copy link
Member Author

The last commit fixed an issue for two-phase flow, marking this as ready to review

@daavid00 daavid00 marked this pull request as ready for review February 14, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants