fix: fix mock logic path; improve configs; improve stack trace reports#5
Merged
hwei0 merged 5 commits intoNetSys:mainfrom Feb 16, 2026
Merged
fix: fix mock logic path; improve configs; improve stack trace reports#5hwei0 merged 5 commits intoNetSys:mainfrom
hwei0 merged 5 commits intoNetSys:mainfrom
Conversation
akrentsel
approved these changes
Feb 16, 2026
Contributor
akrentsel
left a comment
There was a problem hiding this comment.
the requested change can come in a fast-follow change
|
|
||
| experiment_output_dir: /home/hwei/experiment2-out | ||
| client_subdir: client | ||
| zmq_dir: /home/hwei/experiment2-out/zmq |
Contributor
There was a problem hiding this comment.
I don't think hwei should appear in any of these lines. Can the paths be relative to where the directory is cloned perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
tested locally
Checklist: