feat: generate plugin outputs into .plugins folder inside platforms/android#5937
feat: generate plugin outputs into .plugins folder inside platforms/android#5937edusperoni wants to merge 1 commit intomainfrom
Conversation
|
@edusperoni I like the idea! it will break plugins though. actually what you are doing could make things simpler if the plugins folder is added to dependencies repositories. |
|
I don't believe that would change? We still use what's inside the node_modules, but when we generate the aar we put the artifact in the platforms folder. Do you think that wouldn't work? |
|
@edusperoni if i understand the output aar is now in platforms/android/plugins instead of in each node_modules/{plugin}/platforms/android ? |
|
I believe the include.gradle is still parsed in the node modules folder. IRRC it's not a real Gradle file (doesn't get included in full). The decencies are parsed only. |
|
Oh, I see. You're depending on the final artifact. Maybe I'll add some helper functions (some are already present) for plugin developers like |
|
@edusperoni yes that would be awesome. |
instead of writing the generated .aar into the plugin's node_modules folder, write it to
platforms/android/.plugins. This prevents us from modifying node_modules