Ajout des logs de la ceinture d'asteroids#6
Ajout des logs de la ceinture d'asteroids#6baba33mrt wants to merge 2 commits intoNationsTools:mainfrom
Conversation
Added pattern for deleted asteroids log message.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f11b948bdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # =========================== | ||
|
|
||
| asteroids_fail: | ||
| pattern: "{timestamp} [INFO] Failed to delete region file after retries:" |
There was a problem hiding this comment.
Capture failure detail after asteroid retries
This pattern stops at retries: and therefore only matches lines with no trailing content; if the actual log includes the region file or error detail after the colon (the common format for this message), asteroids_fail will never match and failed deletions will be silently missed by the analyzer. Add a trailing placeholder (for example {region_file} or {details}) so real failure entries are parsed.
Useful? React with 👍 / 👎.
Type de modification
Coche au moins une case
Description
Explique clairement :
Ajout des logs de suppression de la ceinture0
Exemple de log réel
Voir @Okinas
Impact potentiel
Justification (si nécessaire) :
Checklist
snake_caseInformations complémentaires
Toute information utile à la revue : /