Skip to content

Comments

Ajout des logs de la ceinture d'asteroids#6

Open
baba33mrt wants to merge 2 commits intoNationsTools:mainfrom
baba33mrt:main
Open

Ajout des logs de la ceinture d'asteroids#6
baba33mrt wants to merge 2 commits intoNationsTools:mainfrom
baba33mrt:main

Conversation

@baba33mrt
Copy link
Member

Type de modification

Coche au moins une case

  • Ajout de pattern
  • Correction de pattern existant
  • Amélioration / clarification
  • Autre (à préciser)

Description

Explique clairement :
Ajout des logs de suppression de la ceinture0

Exemple de log réel

Voir @Okinas

????

Impact potentiel

  • Aucun impact sur les patterns existants
  • Impact rétro-compatible
  • Risque de rupture de compatibilité (à justifier)

Justification (si nécessaire) :

Checklist

  • Le fichier YAML est valide
  • Aucune clé dupliquée
  • Le pattern est dans la bonne catégorie
  • Le nom du pattern est explicite et en snake_case
  • Les variables utilisées sont cohérentes et explicites
  • La modification est justifiée (si pattern existant)

Informations complémentaires

Toute information utile à la revue : /

@baba33mrt baba33mrt requested a review from Okinas February 11, 2026 16:21
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f11b948bdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# ===========================

asteroids_fail:
pattern: "{timestamp} [INFO] Failed to delete region file after retries:"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Capture failure detail after asteroid retries

This pattern stops at retries: and therefore only matches lines with no trailing content; if the actual log includes the region file or error detail after the colon (the common format for this message), asteroids_fail will never match and failed deletions will be silently missed by the analyzer. Add a trailing placeholder (for example {region_file} or {details}) so real failure entries are parsed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant