Skip to content

[TRTC-265][chore] Add CODEOWNERS coverage for serve/ and commands/ directories#11359

Merged
juney-nvidia merged 1 commit intoNVIDIA:mainfrom
venkywonka:venky/update-codeowners
Feb 10, 2026
Merged

[TRTC-265][chore] Add CODEOWNERS coverage for serve/ and commands/ directories#11359
juney-nvidia merged 1 commit intoNVIDIA:mainfrom
venkywonka:venky/update-codeowners

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented Feb 7, 2026

Summary by CodeRabbit

  • Chores
    • Updated code ownership assignments for internal development team organization.

Description

Add trt-llm-llmapi-devs as code owners for /tensorrt_llm/serve/ and /tensorrt_llm/commands/ directories, which previously had no broad CODEOWNERS coverage. Existing specific overrides (commands/bench.pytrtllm-bench-reviewers, serve/openai_disagg_server.pytrt-llm-disagg-devs) continue to take precedence via last-match-wins.

Test Coverage

N/A — CODEOWNERS-only change, no code logic modified.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
@venkywonka venkywonka requested review from a team as code owners February 7, 2026 07:29
@venkywonka venkywonka changed the title [None][chore] Add CODEOWNERS coverage for serve/ and commands/ directories [TRTC-265][chore] Add CODEOWNERS coverage for serve/ and commands/ directories Feb 7, 2026
@venkywonka venkywonka self-assigned this Feb 7, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Added two new CODEOWNERS entries assigning ownership of /tensorrt_llm/serve and /tensorrt_llm/commands directories to a designated team within the TensorRT-LLM LLM API section.

Changes

Cohort / File(s) Summary
Configuration
.github/CODEOWNERS
Added two new code ownership entries for TensorRT-LLM serve and commands directories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding CODEOWNERS coverage for two directories. It follows the required template format with [None][chore] and is specific to the changeset.
Description check ✅ Passed The PR description includes all required sections: a clear explanation of what changed and why, test coverage status, and a completed PR checklist. The content appropriately addresses a CODEOWNERS-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/CODEOWNERS:
- Around line 157-158: The new CODEOWNERS entry for /tensorrt_llm/commands is
currently placed after the more specific /tensorrt_llm/commands/bench.py rule
and therefore overrides bench.py's owners; fix this by either moving the general
"/tensorrt_llm/commands `@NVIDIA/trt-llm-llmapi-devs`" line above the specific
"/tensorrt_llm/commands/bench.py" rule, or re-add/append the
"/tensorrt_llm/commands/bench.py @<bench-owners>" entry after the general
commands line so bench.py retains its dedicated owners.

@juney-nvidia juney-nvidia enabled auto-merge (squash) February 7, 2026 07:46
@venkywonka
Copy link
Collaborator Author

/bot skip --comment "documentation only"

1 similar comment
@venkywonka
Copy link
Collaborator Author

/bot skip --comment "documentation only"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35407 [ skip ] triggered by Bot. Commit: 797f589

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35407 [ skip ] completed with state SUCCESS. Commit: 797f589
Skipping testing for commit 797f589

@juney-nvidia juney-nvidia merged commit d50f010 into NVIDIA:main Feb 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants