[TRTC-265][chore] Add CODEOWNERS coverage for serve/ and commands/ directories#11359
Conversation
Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
📝 WalkthroughWalkthroughAdded two new CODEOWNERS entries assigning ownership of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/CODEOWNERS:
- Around line 157-158: The new CODEOWNERS entry for /tensorrt_llm/commands is
currently placed after the more specific /tensorrt_llm/commands/bench.py rule
and therefore overrides bench.py's owners; fix this by either moving the general
"/tensorrt_llm/commands `@NVIDIA/trt-llm-llmapi-devs`" line above the specific
"/tensorrt_llm/commands/bench.py" rule, or re-add/append the
"/tensorrt_llm/commands/bench.py @<bench-owners>" entry after the general
commands line so bench.py retains its dedicated owners.
|
/bot skip --comment "documentation only" |
1 similar comment
|
/bot skip --comment "documentation only" |
|
PR_Github #35407 [ skip ] triggered by Bot. Commit: |
|
PR_Github #35407 [ skip ] completed with state |
Summary by CodeRabbit
Description
Add
trt-llm-llmapi-devsas code owners for/tensorrt_llm/serve/and/tensorrt_llm/commands/directories, which previously had no broad CODEOWNERS coverage. Existing specific overrides (commands/bench.py→trtllm-bench-reviewers,serve/openai_disagg_server.py→trt-llm-disagg-devs) continue to take precedence via last-match-wins.Test Coverage
N/A — CODEOWNERS-only change, no code logic modified.
PR Checklist