Skip to content

Conversation

@emmagifford
Copy link
Contributor

…r general improvements

Description

This PR includes the following changes to /using-nhs-notify/personalisation:

  • updated the custom personalisation fields to avoid section in line with CCM-10177
  • made general minor style improvements to other parts of the context

Context

See the ticket for the full context. We need to explicitly list all of the fields to avoid, and we need to clarify that punctuation variations will still cause the custom personalisation fields not to work.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@emmagifford emmagifford requested a review from a team as a code owner June 6, 2025 11:25
Copy link
Contributor

@jakecosgrove jakecosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on making some of these more concise!

@jakecosgrove jakecosgrove merged commit 4171cc4 into main Jun 6, 2025
42 checks passed
@jakecosgrove jakecosgrove deleted the custom-personalisation-fields-update branch June 6, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants