CCM-12616 mesh poll retrieve #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapenna-bjss
force-pushed
the
feature/CCM-12616_mesh_poll_retrieve
branch
from
d1e3058 to
331d6c4
Compare
gareth-allan
previously approved these changes
Dec 17, 2025
Contributor
gareth-allan
left a comment
gareth-allan
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of minor points.
| scripts/**/*.*, \ | ||
| docs/**/*.*, \ | ||
| utils/py-mock-mesh/**, \ | ||
| utils/event-publisher-py/event_publisher/mesh_config.py, \ |
Contributor
There was a problem hiding this comment.
Should mesh_config.py not have some test coverage?
Collaborator
Author
There was a problem hiding this comment.
We don't have any tests for the config files in core, so I didn't bother. I can add them if we think they're needed
Contributor
There was a problem hiding this comment.
It does quite a lot, so it might be nice, but I won't block the PR for this. We could always put a TD ticket in perhaps?
Ian-Hodges
changed the title
gareth-allan
previously approved these changes
Dec 17, 2025
tdroza-nhs
previously approved these changes
Dec 17, 2025
Contributor
tdroza-nhs
left a comment
tdroza-nhs
left a comment
There was a problem hiding this comment.
Previous comments addressed
Ian-Hodges
reviewed
Dec 17, 2025
| from pydantic import BaseModel, ConfigDict, Field, field_validator | ||
|
|
||
|
|
||
| class CloudEvent(BaseModel): |
Contributor
There was a problem hiding this comment.
I think you'll need to update the schema otherwise the consuming components will fail when validating them.
lapenna-bjss
dismissed stale reviews from tdroza-nhs and gareth-allan
via
ca56d6e
gareth-allan
previously approved these changes
Dec 18, 2025
tdroza-nhs
previously approved these changes
Dec 18, 2025
aidenvaines-cgi
previously approved these changes
Dec 19, 2025
gareth-allan
dismissed stale reviews from aidenvaines-cgi, tdroza-nhs, and themself
via
c7076d1
….com/NHSDigital/nhs-notify-digital-letters into feature/CCM-12616_mesh_poll_retrieve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two components that together implement the full workflow for pulling and downloading requests submitted to the MESH mailbox.
The first component, mesh-poll, runs every five minutes, reads messages from the MESH inbox, extracts metadata from the message headers, including meshMessageId and messageReference (the MESH local_id), validates the sender by comparing the message’s mailbox ID against sender configurations stored in SSM, and resolves the corresponding senderId. Once validated, mesh-poll publishes a MeshInboxMessageReceived CloudEvent containing senderId, meshMessageId, and messageReference.
The second component, mesh-download, consumes these events via SQS, retrieves the MESH message using the meshMessageId, stores the document in the PII S3 bucket under the document-reference/{senderId}_{messageReference} key, acknowledges the message in MESH (removing it from the inbox), and finally publishes a MeshInboxMessageDownloaded CloudEvent.
Note:
In development environments, the pipeline uses mock MESH
Utils Added
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.