Skip to content

Conversation

@ollietulloch
Copy link
Contributor

@ollietulloch ollietulloch commented Oct 10, 2025

This PR adds the ability to format incoming date-like strings with time components to a Time object.

Previously behaviour:

Value:
'2025-06-01T10:15:36+01:00'

Mapping:

- column: time_field
  mappings:
  - field: time_field
    format: "%Y-%m-%dT%H:%M:%S%:z"

Result:
Sun, 01 Jun 2025 00:00:00 +0100

New behaviour:

Value:
'2025-06-01T10:15:36+01:00'

Mapping:

- column: time_field
  mappings:
  - field: time_field
    format: "%Y-%m-%dT%H:%M:%S%:z"
    time: true

Result:
2025-06-01 10:15:36 +0100

The linting issues have not been introduced by this PR.

Copy link
Contributor

@suezhou suezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ollietulloch ollietulloch merged commit a04845b into main Oct 10, 2025
19 of 20 checks passed
@ollietulloch ollietulloch deleted the feature/format-time-values branch October 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants