Improve performance when handling large XML files with significant column augmentation #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Xml::Tableclass attempts to augment column_mappings based on the data where there might be repeating sections/fields. It does this for eachline, and so can be memory/compute intensive.This PR takes a number of small steps to improve the efficiency, focusing on the
Xml::MaskedMappingsclass.Before this PR, ~1250 repeating sections took ~95 seconds for mapping augmentation. This PR gets that down to ~5.8 seconds.
Some of the small steps...
DO_NOT_CAPTURE_MAPPING = { 'do_not_capture' => true }.freezedeep_duponly when needed.map)Sets