Skip to content

Conversation

@bshand
Copy link
Contributor

@bshand bshand commented Feb 6, 2025

Fix CSV parsing bug. (We were mutating the options hash to remove the :mode, but sometimes this meant we were mutating the cached result, and then passing in a nil mode subsequently. This bug has been revealed by extra checks in the latest csv library.)

Fix concurrent-ruby version to 1.3.4 for older Rails versions

Copy link
Contributor

@ollietulloch ollietulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bshand

@bshand bshand merged commit 41ac177 into main Feb 7, 2025
20 checks passed
@bshand bshand deleted the bugfix/concurrent_ruby_rails70_testing branch February 7, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants