Skip to content

[PRMP-1084] Add document review setup and processing script #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NogaNHS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PRMP-1084] Add document review setup and processing script #987

NogaNHS wants to merge 1 commit into from

Conversation

@NogaNHS
Copy link
Contributor

@NogaNHS NogaNHS commented Jan 6, 2026

Overview

Jira ticket: PRMP-1084

Description

Script for review document feature

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@NogaNHS NogaNHS requested review from a team as code owners January 6, 2026 16:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

steph-torres-nhs
steph-torres-nhs reviewed Jan 6, 2026
View reviewed changes
tests/bulk-upload/scripts/setup_document_review.py
Comment on lines +13 to +20
class DocumentReviewReason(StrEnum):
UNKNOWN_NHS_NUMBER = "Unknown NHS number"
DEMOGRAPHIC_MISMATCHES = "Demographic mismatches"
DUPLICATE_RECORD = "Duplicate records error"
FILE_COUNT_MISMATCH = "More or less files than we expected"
FILE_NAME_MISMATCH = "Filename Naming convention error"
GP2GP_ERROR = "GP2GP failure"
GENERAL_ERROR = "General error"
Copy link
Contributor

@steph-torres-nhs steph-torres-nhs Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be imported? or will it break when running from the action?

Copy link
Contributor Author

@NogaNHS NogaNHS Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not on this branch, waiting for this to be merge to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steph-torres-nhs steph-torres-nhs steph-torres-nhs left review comments

@SteveMahoneyNHS SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NogaNHS @steph-torres-nhs @robg-test @bethany-kish-nhs