Skip to content

Conversation

@dlzhry2nhs
Copy link
Contributor

@dlzhry2nhs dlzhry2nhs commented Dec 29, 2025

Summary

  • Routine Change

Integrates the data quality reports into the batch processing system and the Create and Update endpoints of the Imms FHIR API.

Please refer to the ticket for test evidence of both the logs and the reports which are produced and sent to S3.

  • Sets up infrastructure e.g. env vars so that reports can be sent to S3. Policies should already have been set up.
  • Adds relevant calls and tests to both the Batch and FHIR API parts of the system.
  • Finally, a minor tweak made to the validation model to tighten the datetime validation performed.

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-991

@sonarqubecloud
Copy link

("DATE_AND_TIME", "20241511T120000"), # Invalid datetime
("DATE_AND_TIME", "20241511T120"), # Invalid datetime
("DATE_AND_TIME", "20240520T120001"), # Past dates only
("DATE_AND_TIME", "20240520T150001"), # Past datetime only
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the time is fixed in the test to 2PM UTC on the given date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant