Release/29.0 #1122
Merged
Release/29.0 #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-109>** ## Description of Changes This PR skips the palliative care checks when Palliative Care has never been set on Profile Manager
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-125>** ## Description of Changes Pin back Bandit Version to 1.7.4
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-506>** ## Description of Changes A change to the parser caused an issue with certain steps. This change just replaces the wording so the step definition is unique. ## Type of change Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
…r Aurora (#657) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-550>** ## Description of Changes This PR updates the Security Group Names and Route53 entries to the correct values ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-577>** ## Description of Changes This PR enhances to CodeQL Vulnerability Scanning to run more security checks as well as quality checks.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-125>** ## Description of Changes This PR fixes the latest warning messages from bandit ## Type of change - Bug fix (non-breaking change which fixes an issue)
) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-129>** ## Description of Changes This PR updates to code to Log only Type 13 to Unexpected Pharmacy Profiling Report when multiple type 13s are present.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-578>** ## Description of Changes Adds 2 new integration tests for report error messages regarding service type ## Type of change - Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-118>** ## Description of Changes This PR migrates all pipeline stages from the old pipeline roles to the new pipelines roles ## Type of change - Refactoring (non-breaking change which improves the structure of the code)
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-46>** ## Description of Changes This PR allows palliative care SGSD to be updated in DoS.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-99>** ## Description of Changes Additions to automation tests to enable the checking of database entries when palliative care is enabled. ## Type of change Delete not appropriate - Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-511>** ## Description of Changes This PR adds security headers for the DI Endpoint API Gateway
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-524>** ## Description of Changes This PR adds new documentation diagrams for potential upcoming architectures.
# Task Branch Pull Request ## Description of Changes This PR updates the DoS Version when it refreshes the DoS Environment
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-513>** ## Description of Changes Add Server Access Logging for the send email bucket
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-106>** ## Description of Changes This PR validates that an SDSGID exists within the database. If it doesn't it logs to the generic error report and alerts to the slack channel.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-638>** ## Description of Changes This PR encrypts objects uploaded to the S3 send email bucket.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-673>** ## Description of Changes This PR reverts back to previous db endpoints
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-705>** ## Description of Changes This PR fixes an issue with the S3 ACL/object ownership configuration.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-705>** ## Description of Changes This PR removes the Server Access Logging bucket to remove the issue with ACLs. This feature will be restored after release 12.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-705>** ## Description of Changes This PR fixes where the send email bucket is dependant on the commented out logging bucket.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-717>** ## Description of Changes This PR changes the branch prefix from DSUEC to DS to ensure that the delete environment jobs work.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-711>** ## Description of Changes This PR fixes the perf2 environment configuration.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-128>** ## Description of Changes This PR adds an architectural decision record to explain the decision to remove the orchestrator to improve performance.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-719>** ## Description of Changes This PR improves palliative care logging by updating f strings and fixing log messages.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-744>** ## Description of Changes This PR adds a bunch of changes to CloudWatch resources to make monitoring and support easier.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-747>** ## Description of Changes This PR adds a Data Item metric to show what is being updated. This is on a per data item being updated so if postcode is updated, town, easting, northing, latitude and longitude updates are also recorded.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-707>** ## Description of Changes This PR adds server access logging to the send email bucket that follows the new AWS policies.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-774>** ## Description of Changes This PR fixes F001SXX3 integration test by making the assertion work. As well making the comparison values correct for the assertion.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-780>** ## Description of Changes This PR updates all files in the Application folder to meet Ruff standards.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3268>** ## Description of Changes This PR updates the lambda image builder for pipelines to use an arm based CodeBuild job. The 86x version stopped working due to an inability to install the docker xbuild plugin. The arm builder we use for task environments has not been affect by this issue. As such it makes sense to align the non-pipeline builder with the pipeline builder and have both CodeBuild jobs use an arm based container to build arm based images. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3019>** ## Description of Changes This PR includes the upgrade of AWS Terraform provider to version 5.68.0 ## Type of change - Infrastructure upgrade change ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester Co-authored-by: ajmu1 <ajmu1@hscic.gov.uk>
…te (#1038) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3293>** ## Description of Changes Updating date to a future date for open timings integration test ## Type of change - Integration test case scenario change for open timings ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2843>** ## Description of Changes This PR change enables the delete protection on change event DB in prod environment. This delete protection not enabled on any other env as we will require to tear the lower envs down after the development/testing purpose is fulfilled and tested in these lower env and hence it's enabled for prod env only to avoid accidental deletion of DB ## Type of change Delete not appropriate - Security enhancement for dynamodb table in prod env ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2844>** ## Description of Changes This PR creates a custom WAF rule to identify the SQL injection attacks in change event request. Please include a summary of the change ## Type of change - Security enhancements(Prevention of SQL injections) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-392>** ## Description of Changes Please include a summary of the change ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactoring (non-breaking change which improves the structure of the code) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3492>** ## Description of Changes Sorting priority order of WAF rules for AWS managed and custom rules. ## Type of change - Security enhancements(Monitoring of SQL injections) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3556>** ## Description of Changes Enabling podman to run make targets locally along with docker. ## Type of change - DI Reworking/Tooling ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester --------- Signed-off-by: Matthew Begley <60427904+mabe13@users.noreply.github.com> Co-authored-by: Matthew Begley <60427904+mabe13@users.noreply.github.com>
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3746>** ## Description of Changes Change Smoke test service as the current one has been removed ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) (Test bug) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3859>** ## Description of Changes Transferring dos-integration repo from nhsd-exeter to NHSDigital organisation ## Type of change - Engineering Red Lines Resilience ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>** ## Description of Changes Fixing development pipeline triggering ## Type of change - Bug fix (Fixing development pipeline triggering post PR merge) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>** ## Description of Changes This PR revert changes from the last PR #1069 ## Type of change - Bug fix (reverting changes from last PR #1069) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>** ## Description of Changes Updated github PAT to fix dev pipeline trigger ## Type of change - Bug fix (Fixing dev pipeline trigger) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>** ## Description of Changes This PR is to test the development pipeline trigger after manual release pushed from AWS CP post the org transfer ## Type of change - Bug fix (Development pipeline trigger fix) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3730>** ## Description of Changes Remove DSP from invalid palliative care type check, as it valid for them to have it. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
#1084) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-4012>** ## Description of Changes DevOps change ## Type of change - DevOps configurations change ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-4012>** ## Description of Changes Please include a summary of the change ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactoring (non-breaking change which improves the structure of the code) ## Development Checklist - [ ] I have performed a self-review of my own code - [ ] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [ ] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-4011>** ## Description of Changes Change to improve CI/CD pipelines ## Type of change Delete not appropriate - Refactoring (CI/CD pipelines enhancements) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>** ## Description of Changes Fixing issue of breaking test cases in new tester docker image ## Type of change - Bug fix (CI/CD pipeline related change) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>** ## Description of Changes Fixing arch image versions for test case related AWS codebuild jobs only ## Type of change - Bug fix (CI/CD pipeline related change to fix breaking of test cases in new tester image) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>** ## Description of Changes Fixing breaking test cases for new tester image in CI/CD pipeline ## Type of change - Bug fix (CI/CD pipeline related change to fix issue with new tester image) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>** ## Description of Changes Temporarily fixing the smoke test demo stage for amr64 type. ## Type of change Delete not appropriate - Bug fix (Fixing breaking test cases in CI/CD pipeline issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-4277>** ## Description of Changes Addressing utilities and python libraries vulnerabilities identified by Dependabot ## Type of change - Security vulnerability fixes in utilities and python libs identified by dependabot ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
|
mabe13
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Branch Pull Request
Description of Changes
This release was focused around fixing quality check report issue and addressing vulnerabilities in utils and python libs