Skip to content

Conversation

@ajmu1
Copy link
Collaborator

@ajmu1 ajmu1 commented Jan 13, 2025

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2843

Description of Changes

This PR change enables the delete protection on change event DB in prod environment. This delete protection not enabled on any other env as we will require to tear the lower envs down after the development/testing purpose is fulfilled and tested in these lower env and hence it's enabled for prod env only to avoid accidental deletion of DB

Type of change

Delete not appropriate

  • Security enhancement for dynamodb table in prod env

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@ajmu1 ajmu1 requested a review from mabe13 January 13, 2025 16:48
@sonarqubecloud
Copy link

@ajmu1 ajmu1 changed the title Task/ds 2843 enable ddb delete protection DS-2843 Enable dynamodb delete protection for live profile Jan 13, 2025
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ajmu1 ajmu1 merged commit 7144815 into develop Jan 16, 2025
22 of 28 checks passed
@ajmu1 ajmu1 deleted the task/DS-2843_Enable_ddb_delete_protection branch January 16, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants