Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the first working version for GSSAPI integration into the LDAP client using SASL bind, providing necessary dependency updates, example usage, and Docker configuration.
- Added the "gssapi" dependency in pyproject.toml.
- Introduced a new gssapi_example function in main.py demonstrating GSSAPI usage.
- Updated aioldap3.py with SASL GSSAPI support and integrated channel bindings.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Added dependency for gssapi and removed some mypy plugins. |
| main.py | Implemented a GSSAPI example using the new aioldap3 module. |
| docker-compose.yml | Configured container settings for the aioldap service. |
| aioldap3.py | Added SASL GSSAPI functions, channel bindings support, and updated SASL flow. |
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
aioldap3.py:865
- [nitpick] The function name 'proccess_end_token' is misspelled; consider renaming it to 'process_end_token' for improved clarity.
def proccess_end_token(self, token: bytes) -> bytearray:
Collaborator
Author
|
Мёрдж временно приостановлен из за невостребованности фичи |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.