Skip to content

fix: Do not log patch name more than once if disabled#49

Merged
LisoUseInAIKyrios merged 5 commits intoMorpheApp:devfrom
prateek-who:duplicate-log-fix
Feb 14, 2026
Merged

fix: Do not log patch name more than once if disabled#49
LisoUseInAIKyrios merged 5 commits intoMorpheApp:devfrom
prateek-who:duplicate-log-fix

Conversation

@prateek-who
Copy link

@prateek-who prateek-who commented Feb 13, 2026

Moved the "compatibility check" block before the "patches get disabled" block making sure the cli keeps only the needed patches for our app and then disables those patches. Should fix #23

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: Duplicate logs fix fix: Do not show patch name more than once if disabled Feb 13, 2026
@LisoUseInAIKyrios

This comment was marked as resolved.

@prateek-who

This comment was marked as resolved.

@prateek-who

This comment was marked as resolved.

@prateek-who

This comment was marked as resolved.

@LisoUseInAIKyrios
Copy link
Contributor

I tested just now, and it seems to work 👍

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix: Do not show patch name more than once if disabled fix: Do not log patch name more than once if disabled Feb 14, 2026
@LisoUseInAIKyrios
Copy link
Contributor

Something isn't quite right with using a lower case patch name with a patch option.

This works and the app shows in the launcher as "YouTube Foo", and a "custom" menu is available in the YouTube Morphe general settings.
-e "Custom branding" -OcustomName="YouTube Foo"

But this does not work. The option is not recognized and the custom name doesn't show.
-e "custom branding" -OcustomName="YouTube Foo"

@prateek-who
Copy link
Author

Yea, I see it now. The enabling/ disabling logic is case insensitive but options map isn't applying the lowercase logic. Now we just have a new resolvedName that does the case insensitive matching first with the user input and then properly passes the matched element as the key. Try this once and see if it works.

@LisoUseInAIKyrios
Copy link
Contributor

Yes it's working now. Will merge this in a few hours from now.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Feb 14, 2026 that may be closed by this pull request
2 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit b980bb8 into MorpheApp:dev Feb 14, 2026
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 14, 2026
# [1.4.0-dev.5](v1.4.0-dev.4...v1.4.0-dev.5) (2026-02-14)

### Bug Fixes

* Do not log patch name more than once if disabled ([#49](#49)) ([b980bb8](b980bb8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Duplicate log entries when disabling patches via -d flag

2 participants