fix(web): lazy-load scalar-fastapi docs UI#992
Open
szj2ys wants to merge 2 commits intoMoonshotAI:mainfrom
Open
fix(web): lazy-load scalar-fastapi docs UI#992szj2ys wants to merge 2 commits intoMoonshotAI:mainfrom
szj2ys wants to merge 2 commits intoMoonshotAI:mainfrom
Conversation
Avoid importing scalar-fastapi at module import time so the Web UI can still start when the docs UI dependency is unavailable. Add a smoke test asserting create_app() can be imported and constructed.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scalar-fastapi.Changes
src/kimi_cli/web/app.py: movescalar_fastapiimport behind a best-effort helper; return 503 for/docswhen unavailable.tests/test_web_app_import.py: add a smoke test that imports and constructscreate_app().Test Plan
uv run --python 3.13 pytest -q tests/test_web_app_import.pyRelated Issues