Skip to content

Add support for run tokens.#1051

Open
LexManos wants to merge 2 commits intoMinecraftForge:FG_7.0from
LexManos:run-tokens
Open

Add support for run tokens.#1051
LexManos wants to merge 2 commits intoMinecraftForge:FG_7.0from
LexManos:run-tokens

Conversation

@LexManos
Copy link
Member

Initial work on fixing #1048 (and older versions)
Mavenizer will need an update to support outputting mcp_version, mc_version, and modules
Slime Launcher will need to be updated as well, maybe make it responsible for mcp_version/mc_version from metadata.

Not sure what to do with extracting the natives, I think Slime should be responsible for that as well.

Did a little reorganizing, moved the register methods for Metadata/Eclipse to their own class.
Made MinecraftDependencyInternal expose a lot more data.
Made MinecraftDependecyInternal hold references to things that will be used by multiple runes, the metadata task, dependency configurations, etc..

@LexManos LexManos marked this pull request as ready for review February 28, 2026 00:18
@LexManos
Copy link
Member Author

Should be good to go, Bumped Mavenizer to expose the module list.
I have verified it works with 1.20.2 which uses {module} and {runtime_classpath_file}
The only pending things left that I have not implemented are {mcp_to_srg} and {source_roots}
I don't know what versions use {mcp_to_srg}, nothing shows up in search, and haven't written a scraper to figure that out.

It should be good to go, just want someone besides me to verify as its a fairly big change.

I've also included my Eclipse Run config changes from ForgeDev.
As well as cleaning up the MavenizerSync check flow stuff, as its not needed anymore with the new ValueSource approach.

@Swackyy
Copy link

Swackyy commented Feb 28, 2026

Took a bit of fiddling with gradle shenanigans but it works on my (multiloader) end well, aside from it not finding my mod during mod discovery it seems. Probably an issue on my part although I am mentioning it due to the possibility of it not being me
image

@LexManos
Copy link
Member Author

Nice verification that it works on someone elses machine is always good. As for not being able to find your mod. That might be the source_roots token.


Is that meing used anywhere in your launch args?

@Swackyy
Copy link

Swackyy commented Feb 28, 2026

Doesn't seem to be, searched my console and scanned the ModLauncher running: args [] array printed but nothing

@LexManos
Copy link
Member Author

Interesting. If you wanna donate a zip of your setup (or github link) i can take a look when im back home.

@Swackyy
Copy link

Swackyy commented Feb 28, 2026

Sure here, this will grab the plugin from maven though, so if you need to change the version or something to test, the forge build.gradle is located here: loader/forge/build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants