Open
Conversation
Port eclipse run config fixes from ForgeDev
Member
Author
Member
Author
|
Nice verification that it works on someone elses machine is always good. As for not being able to find your mod. That might be the source_roots token. Is that meing used anywhere in your launch args? |
|
Doesn't seem to be, searched my console and scanned the |
Member
Author
|
Interesting. If you wanna donate a zip of your setup (or github link) i can take a look when im back home. |
|
Sure here, this will grab the plugin from maven though, so if you need to change the version or something to test, the forge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Initial work on fixing #1048 (and older versions)
Mavenizer will need an update to support outputting mcp_version, mc_version, and modules
Slime Launcher will need to be updated as well, maybe make it responsible for mcp_version/mc_version from metadata.
Not sure what to do with extracting the natives, I think Slime should be responsible for that as well.
Did a little reorganizing, moved the register methods for Metadata/Eclipse to their own class.
Made MinecraftDependencyInternal expose a lot more data.
Made MinecraftDependecyInternal hold references to things that will be used by multiple runes, the metadata task, dependency configurations, etc..