Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Jan 30, 2026

  • Switch from file-based SQLite databases to :memory: databases in e2e tests
  • Prevents test pollution from persisted database files between test runs
  • Affects bip39-identity-recovery.test.ts and remote-comms.test.ts
    • I observed failures in the BIP-39 tests on repeated local runs, probably due to db file reuse.

Note

Low Risk
Low risk: changes are confined to NodeJS e2e test setup/fixtures and only affect how test databases are created, with no production logic impact. Main risk is subtle differences in SQLite :memory: lifecycle causing unexpected test behavior if any test relied on persistence across connections.

Overview
E2E test isolation improvement: updates NodeJS e2e tests to create SQLite databases with dbFilename: ':memory:' instead of writing per-test .db files.

This applies to the BIP39 identity recovery and remote comms suites, reducing cross-run pollution/flakiness by ensuring each kernel/test uses ephemeral storage.

Written by Cursor Bugbot for commit 539e189. This will update automatically on new commits. Configure here.

Switch from file-based SQLite databases to :memory: databases in e2e
tests to prevent test pollution from persisted database files between
test runs.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rekmarks rekmarks requested a review from a team as a code owner January 30, 2026 06:17
@rekmarks rekmarks enabled auto-merge January 30, 2026 06:19
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.41%
🟰 ±0%
5883 / 6654
🔵 Statements 88.3%
🟰 ±0%
5980 / 6772
🔵 Functions 87.12%
🟰 ±0%
1529 / 1755
🔵 Branches 84.59%
🟰 ±0%
2130 / 2518
File CoverageNo changed files found.
Generated in workflow #3488 for commit 539e189 by the Vitest Coverage Report Action

Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better isolation is good.

@rekmarks rekmarks added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit cdbb226 Jan 30, 2026
32 checks passed
@rekmarks rekmarks deleted the rekm/use-memory-db-in-e2e-tests branch January 30, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants