Skip to content

refactor: replace sinon with Jest timers and mocks #7796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
cryptodev-2s wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: replace sinon with Jest timers and mocks #7796

cryptodev-2s wants to merge 2 commits into from
+164 −131

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jan 30, 2026

Explanation

Replace sinon with Jest timers and mocks

  • Remove sinon and @types/sinon from 21 packages
  • Replace sinon.useFakeTimers() with jest.useFakeTimers()
  • Replace sinon.stub() with jest.fn() or jest.spyOn()
  • Replace sinon.spy() with jest.fn()
  • Replace sinon.restore() with jest.restoreAllMocks()
  • Update advanceTime helper to use jest.advanceTimersByTime()
  • Convert sinon assertion patterns to Jest equivalents:
    • .callCount → toHaveBeenCalledTimes()
    • .called → toHaveBeenCalled()
    • .calledWith() → toHaveBeenCalledWith()
    • .firstCall.args → .mock.calls[0]
    • .getCall(n).args → .mock.calls[n]

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@cryptodev-2s cryptodev-2s force-pushed the refactor/replace-sinon-with-jest-timers branch 8 times, most recently from 83710f5 to e3ca2e6 Compare January 30, 2026 20:32
@cryptodev-2s
chore: remove unused sinon dependency from 4 packages
a0852cd 
Remove sinon from devDependencies in packages where it was declared
but not actually used:
- app-metadata-controller
- approval-controller
- core-backend
- selected-network-controller
@cryptodev-2s cryptodev-2s force-pushed the refactor/replace-sinon-with-jest-timers branch 3 times, most recently from fe3514d to 2069bf0 Compare January 30, 2026 23:03
@cryptodev-2s
chore: replace sinon with jest in phishing-controller
c696592 
Migrate all test files from sinon fake timers to Jest fake timers
and manual time control pattern for async test compatibility.
@cryptodev-2s cryptodev-2s force-pushed the refactor/replace-sinon-with-jest-timers branch from 2069bf0 to c696592 Compare January 30, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cryptodev-2s