Fix that registered classes are not added to the designated package#261
Merged
Fix that registered classes are not added to the designated package#261
Conversation
mrbean-bremen
approved these changes
Apr 30, 2025
if they were implicitly added first (to PythonQt.private), and the explicit register method isn't given a Python module object, only a name. Fixes #260
usiems
force-pushed
the
fix_missing_QtCore_QObject
branch
from
140242d to
e1649c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if they were implicitly added first (to PythonQt.private), and the explicit register method isn't given a Python module object, only a name.
Fixes #260
Class QObject is implicitly registered first because PythonQt registers two interface objects that are derived from QObject.