Skip to content

changed field styles#136

Merged
sahehb merged 5 commits intomainfrom
field_style
Feb 5, 2026
Merged

changed field styles#136
sahehb merged 5 commits intomainfrom
field_style

Conversation

@sahehb
Copy link
Collaborator

@sahehb sahehb commented Feb 2, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

A preview of b493266 is uploaded and can be seen here:

https://mevislab.github.io/examples/pull/136/

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/MeVisLab/examples/tree/gh-pages/pull/136/

Copy link
Contributor

@okonrad okonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should think and discuss about it again.

On the one hand, we should not style everything, on the other hand, we should make it clear if we mean a field, a value, code, or an attribute. For the reader and for future writers.

For fields, we have a <field>fieldName</field>. Maybe rename it to <fieldName>fieldName</fieldName> to make it clearer.

Values do not have to be styled, but it would be nice to easily see them. Maybe just use a monospaced font without any color change. Maybe we can use <fieldValue>fieldValue</fieldValue> or something similar.

Code should be styled as code, like code in here (monospaced font with a background). Examples for code are internalName = FooBar and expandX = Yes.

Attributes are similar to code and could be styled similar - if at all. Examples for attributes are MinDistance (in a vessel skeleton) and type (in an MDL declaration of a new field).

@sahehb sahehb merged commit bb51ab3 into main Feb 5, 2026
1 check passed
@sahehb sahehb deleted the field_style branch February 5, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants