repr: ByteString to represent u8 vectors#35017
Open
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Open
repr: ByteString to represent u8 vectors#35017antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Introduce explicit `ByteString` type to represent byte vectors. This creates more clarity around types (it's not multiple byte arguments) and allows us to have implementations for vectors that would otherwise conflict. No behavior changes expected. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce explicit
ByteStringtype to represent byte vectors. This creates more clarity around types (it's not multiple byte arguments) and allows us to have implementations for vectors that would otherwise conflict. No behavior changes expected.