[SS-63][Oneshot Sources] Fix race condition in Oneshot Ingestion related to multiple Timely Workers#35006
Open
patrickwwbutler wants to merge 9 commits intoMaterializeInc:mainfrom
Open
Conversation
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race condition in which the first timely worker begins to process an ingestion, fails receives an error that cancels the operation very quickly, before the other timely workers actually render the dataflow and begin working. Then, the now-removed code would drop the ingestion, including the
PressOnDropbuttons from that worker. This would then result in the other timely workers waiting for results/progress from the first worker forever.By removing this early ingestion drop logic from the worker, and allowing the
StorageControllerto drop it from all workers when the ingestion is fully completed, we can avoid this race condition.Verification
This now passes the
copy_from_s3_minio.tdtest with multiple replicas, and larger cluster sizes.