Skip to content

bin/scratch: rename 'mine' subcommand to 'list' and 'who' arg to 'owner'#35002

Merged
aljoscha merged 1 commit intoMaterializeInc:mainfrom
aljoscha:push-wyqwlsrzzpxt
Feb 16, 2026
Merged

bin/scratch: rename 'mine' subcommand to 'list' and 'who' arg to 'owner'#35002
aljoscha merged 1 commit intoMaterializeInc:mainfrom
aljoscha:push-wyqwlsrzzpxt

Conversation

@aljoscha
Copy link
Contributor

Rename the 'mine' subcommand to 'list' for clarity, since the command lists scratch instances and isn't limited to showing your own. Also rename the positional 'who' argument to 'owner' to better describe its purpose.

Update documentation in doc/developer/scratch.md accordingly.

Note: other subcommands (ssh, sftp, push, forward, destroy) accept the literal string 'mine' as an instance ID shorthand to refer to your only live instance. This is a separate concept from the subcommand name and is intentionally left unchanged.

@aljoscha aljoscha requested review from def-, jubrad and teskje February 13, 2026 15:46
@github-actions
Copy link

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def-
Copy link
Contributor

def- commented Feb 13, 2026

Should we maybe keep an alias for the old mine subcommand?

@aljoscha
Copy link
Contributor Author

Should we maybe keep an alias for the old mine subcommand?

Could, but I feel like a clean cut is better. We don't have automated tooling using this, do we?

@def-
Copy link
Contributor

def- commented Feb 13, 2026

Nope!

Rename the 'mine' subcommand to 'list' for clarity, since the command
lists scratch instances and isn't limited to showing your own. Also
rename the positional 'who' argument to 'owner' to better describe its
purpose.

Update documentation in doc/developer/scratch.md accordingly.

Note: other subcommands (ssh, sftp, push, forward, destroy) accept the
literal string 'mine' as an instance ID shorthand to refer to your only
live instance. This is a separate concept from the subcommand name and
is intentionally left unchanged.
@aljoscha aljoscha merged commit b0933b2 into MaterializeInc:main Feb 16, 2026
5 checks passed
@aljoscha aljoscha deleted the push-wyqwlsrzzpxt branch February 16, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants