fix: close file descriptors in Requests-style file tuples #414
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users pass files using the Requests API format
{'key': ('filename', fileobj, ...)}, the inner fileobj
was not being closed by _close_file_descriptors.
This could lead to resource leaks in uploads.
- Extend _close_file_descriptors to detect and close
file objects inside file-tuple values.
- Add unit test to verify the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users pass files using the Requests API format {'key': ('filename', fileobj, ...)}, the inner fileobj was not being closed by _close_file_descriptors.
This could lead to resource leaks in uploads.