Skip to content
/ server Public

MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahmoud-kh1 wants to merge 1 commit into
base: main
Choose a base branch
from
+113 −5
Open

MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle #4649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions mysql-test/suite/compat/oracle/r/func_to_date_urdu.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
#
# Urdu (Pakistan) TO_DATE test
#
SET NAMES utf8mb4;
SELECT TO_DATE('15 جنوری 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jan;
jan
2024-01-15 00:00:00
SELECT TO_DATE('15 فروری 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS feb;
feb
2024-02-15 00:00:00
SELECT TO_DATE('15 مارچ 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS mar;
mar
2024-03-15 00:00:00
SELECT TO_DATE('15 اپریل 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS apr;
apr
2024-04-15 00:00:00
SELECT TO_DATE('15 مئی 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS may;
may
2024-05-15 00:00:00
SELECT TO_DATE('15 جون 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jun;
jun
2024-06-15 00:00:00
SELECT TO_DATE('15 جولائی 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jul;
jul
2024-07-15 00:00:00
SELECT TO_DATE('15 اگست 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS aug;
aug
2024-08-15 00:00:00
SELECT TO_DATE('15 ستمبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS sep;
sep
2024-09-15 00:00:00
SELECT TO_DATE('15 اکتوبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS oct;
oct
2024-10-15 00:00:00
SELECT TO_DATE('15 نومبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS nov;
nov
2024-11-15 00:00:00
SELECT TO_DATE('15 دسمبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS `dec`;
dec
2024-12-15 00:00:00
# Testing Monday (پیر) date: 2026-02-09
SELECT TO_DATE('09-02-2026 پیر', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS mon;
mon
2026-02-09 00:00:00
# Testing Tuesday (منگل) date: 2026-02-10
SELECT TO_DATE('10-02-2026 منگل', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS tue;
tue
2026-02-10 00:00:00
# Testing Wednesday (بدھ) date: 2026-02-11
SELECT TO_DATE('11-02-2026 بدھ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS wed;
wed
2026-02-11 00:00:00
# Testing Thursday (جمعرات) date: 2026-02-12
SELECT TO_DATE('12-02-2026 جمعرات', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS thu;
thu
2026-02-12 00:00:00
# Testing Friday (جمعہ) date: 2026-02-13
SELECT TO_DATE('13-02-2026 جمعہ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS fri;
fri
2026-02-13 00:00:00
# Testing Saturday (ہفتہ) date: 2026-02-14
SELECT TO_DATE('14-02-2026 ہفتہ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS sat;
sat
2026-02-14 00:00:00
# Testing Sunday (اتوار) date: 2026-02-15
SELECT TO_DATE('15-02-2026 اتوار', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS sun;
sun
2026-02-15 00:00:00
40 changes: 40 additions & 0 deletions mysql-test/suite/compat/oracle/t/func_to_date_urdu.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
--echo #
--echo # Urdu (Pakistan) TO_DATE test
--echo #

SET NAMES utf8mb4;

SELECT TO_DATE('15 جنوری 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jan;
SELECT TO_DATE('15 فروری 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS feb;
SELECT TO_DATE('15 مارچ 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS mar;
SELECT TO_DATE('15 اپریل 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS apr;
SELECT TO_DATE('15 مئی 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS may;
SELECT TO_DATE('15 جون 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jun;
SELECT TO_DATE('15 جولائی 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS jul;
SELECT TO_DATE('15 اگست 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS aug;
SELECT TO_DATE('15 ستمبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS sep;
SELECT TO_DATE('15 اکتوبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS oct;
SELECT TO_DATE('15 نومبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS nov;
SELECT TO_DATE('15 دسمبر 2024', 'DD MONTH YYYY', 'NLS_DATE_LANGUAGE=URDU') AS `dec`;


--echo # Testing Monday (پیر) date: 2026-02-09
SELECT TO_DATE('09-02-2026 پیر', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS mon;

--echo # Testing Tuesday (منگل) date: 2026-02-10
SELECT TO_DATE('10-02-2026 منگل', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS tue;

--echo # Testing Wednesday (بدھ) date: 2026-02-11
SELECT TO_DATE('11-02-2026 بدھ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS wed;

--echo # Testing Thursday (جمعرات) date: 2026-02-12
SELECT TO_DATE('12-02-2026 جمعرات', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS thu;

--echo # Testing Friday (جمعہ) date: 2026-02-13
SELECT TO_DATE('13-02-2026 جمعہ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS fri;

--echo # Testing Saturday (ہفتہ) date: 2026-02-14
SELECT TO_DATE('14-02-2026 ہفتہ', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS sat;

--echo # Testing Sunday (اتوار) date: 2026-02-15
SELECT TO_DATE('15-02-2026 اتوار', 'DD-MM-YYYY DAY', 'NLS_DATE_LANGUAGE=URDU') AS sun;
2 changes: 1 addition & 1 deletion mysql-test/suite/sys_vars/r/lc_time_names_func.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ sexta Sex janeiro Jan quarta dezembro
SET @@session.lc_time_names = 'ur_PK';
SELECT DATE_FORMAT('2010-01-01','%W %a %M %b'), DAYNAME('2010-05-05'),MONTHNAME('2010-12-12');
DATE_FORMAT('2010-01-01','%W %a %M %b') DAYNAME('2010-05-05') MONTHNAME('2010-12-12')
جمعه جمعه جنوري جنوري بدھ دسمبر
جمعہ جمعہ جنوری جنوری بدھ دسمبر
SET @@global.lc_time_names = "en_US";
8 changes: 4 additions & 4 deletions sql/sql_locale.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1979,13 +1979,13 @@ MY_LOCALE my_locale_uk_UA

/***** LOCALE BEGIN ur_PK: Urdu - Pakistan *****/
static const char *my_locale_month_names_ur_PK[13] =
{"جنوري","فروري","مارچ","اپريل","مٓی","جون","جولاي","اگست","ستمبر","اكتوبر","نومبر","دسمبر", NullS };
{"جنوری","فروری","مارچ","اپریل","مئی","جون","جولائی","اگست","ستمبر","اکتوبر","نومبر","دسمبر", NullS };
static const char *my_locale_ab_month_names_ur_PK[13] =
{"جنوري","فروري","مارچ","اپريل","مٓی","جون","جولاي","اگست","ستمبر","اكتوبر","نومبر","دسمبر", NullS };
{"جنوری","فروری","مارچ","اپریل","مئی","جون","جولائی","اگست","ستمبر","اکتوبر","نومبر","دسمبر", NullS };
static const char *my_locale_day_names_ur_PK[8] =
{"پير","منگل","بدھ","جمعرات","جمعه","هفته","اتوار", NullS };
{"پیر","منگل","بدھ","جمعرات","جمعہ","ہفتہ","اتوار", NullS };
static const char *my_locale_ab_day_names_ur_PK[8] =
{"پير","منگل","بدھ","جمعرات","جمعه","هفته","اتوار", NullS };
{"پیر","منگل","بدھ","جمعرات","جمعہ","ہفتہ","اتوار", NullS };
static TYPELIB my_locale_typelib_month_names_ur_PK =
CREATE_TYPELIB_FOR(my_locale_month_names_ur_PK);
static TYPELIB my_locale_typelib_ab_month_names_ur_PK =
Expand Down