MDEV-30953 Add mariadb server galera package#4644
MDEV-30953 Add mariadb server galera package#4644grooverdan wants to merge 2 commits intoMariaDB:12.3from
Conversation
Add new package mariadb-server-galera to Debian to recude mariadb-server package dependencies. Galera cluster scripts and libraries are currently in package mariadb-server. Move Galera cluster scripts and libraries to new package mariadb-server-galera as most of the people does not need them and it allows to slim down mariadb-server package
Add new package mariadb-server-galera to RPM build recude mariadb-server package dependencies. Galera cluster scripts and libraries are currently in package mariadb-server. Move Galera cluster scripts and libraries to new package mariadb-server-galera as most of the people does not need them and it allows to slim down mariadb-server package
|
I am trying to understand the context here. Seems branch 'main' got a865a7c five days ago and it was already released with MariaDB 12.3.1. The commit only has a title ("MDEV-38744 remove galera dependency from server packages") and no body. The Jira MDEV-38744 created 10 days ago has the description "remove galera dependency from server packages. from bintars too." and nothing else. |
| Package: mariadb-server-galera | ||
| Architecture: any | ||
| Depends: galera-4 (>= 26.4), | ||
| gawk, |
There was a problem hiding this comment.
The file will be consistently formatted if you run wrap-and-sort -vast or debputy reformat --style black like was done in 5ed3668.
| This package is also useful for users with strong background in MySQL | ||
| maintenance, but wants to switch to MariaDB | ||
|
|
||
| Package: mariadb-server-galera |
There was a problem hiding this comment.
Or maybe mariadb-plugin-galera like the other plugins if that is what your plan is?
| ${misc:Depends}, | ||
| ${shlibs:Depends} | ||
| Conflicts: mariadb-server (<< 12.3) | ||
| Breaks: mariadb-server (<< 1:12.3) |
There was a problem hiding this comment.
I haven't tested, but I suspect this also needs a Replaces: mariadb-server (<< 1:12.3.2) and that all versions should be 1:12.3.2?
| MariaDB Galera Cluster is a virtually synchronous multi-primary | ||
| cluster for MariaDB. | ||
| . | ||
| Galera Cluster needs this package |
There was a problem hiding this comment.
This repeats the title. How about:
Description: MariaDB scripts and configuration needed by Galera cluster
MariaDB Galera Cluster is a virtually synchronous multi-primary
cluster for MariaDB.
.
Galera is the underlying replication plugin that makes this clustering
possible. It provides write-set replication with group communication
primitives to ensure data consistency across all nodes in real-time.
.
The library enables active-active multi-master topologies with automatic
membership control, supports both incremental (IST) and snapshot (SST)
state transfers, and guarantees no transaction loss on node failures
through its virtually synchronous replication protocol.
Yep, I'm ranting a bit on this already, because the context is new to me too. Since its also excluded from the release mirrors and archives and release notes. Thanks for the rest of the comments. |
|
I do not know is this good solution. I have advocated that galera library should be submodule or external project for server so that bind between server release and galera library would be more explicit. But, it naturally effects on packages so not sure if it doable. |
For the purposes of packaging it does not matter if Galera is a submodule or how it is done. For example libmariadb is a submodule but built and shipped with the server. I guess the main question here is what is the goal, and then that dictates what is the best path to it. |
MDEV-38744 remove galera dependency from server packages, broke the ability of a user to easily install a Galera system.
This broke the container builds in CI.
Rather than leaving a bunch of galera scripts in the server package (that cannot be run without dependencies), lets complete the transition and provide something useful for Galera users and the MariaDB container.
Because a MariaDB-server-galera configuration on the user side is now explicit, we enable minimum galera configuration for the Deb installation.