Conversation
There was a problem hiding this comment.
As per https://mariadb.com/kb/en/mariadb-upgrade/
You should run mariadb-upgrade after upgrading from one major MySQL/MariaDB release to another
Running mariadb-upgrade if [[ $test_type == "major" ]] will suffice.
Right now, we are doing things a bit differently between RPM and DEB as:
For DEB is wrong because it won't evaluate as true in most cases.
if [[ $major_version == "$development_branch" ]]; then
sudo mariadb-upgrade
fi
And for RPM we are lucky we have the OR major upgrade condition.
if [[ $major_version == "$development_branch" ]] || [[ $test_type == "major" ]]; then
sudo mariadb-upgrade
fi
Another thought is that mariadb-upgrade can catch early incompatibilities for minor upgrades too. So why not remove any condition and run it everytime, no matter the test_type?
It's also safe to run mariadb-upgrade for minor upgrades, as if there are no incompatibilities nothing is changed.
@cvicentiu any thoughts on this?
d7eb898 to
4be5d7c
Compare
This affects how and which install/upgrade tests are done.
c81b059 to
3358c87
Compare
This affects how and which install/upgrade tests are done.