Handle cases where the postMessage is not a valid json#23
Open
kwadwo wants to merge 2 commits intoMailOnline:masterfrom
Open
Handle cases where the postMessage is not a valid json#23kwadwo wants to merge 2 commits intoMailOnline:masterfrom
kwadwo wants to merge 2 commits intoMailOnline:masterfrom
Conversation
iq-dot
added a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
Add client config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used on a page with other adUnits & elements that rely on postMessages, the window receives multiple messages which are not necessary valid JSON. This PR adds a check so that it doesn't throw a lot of console errors. when doing
JSON.parseon all messages.