Immersed boundaries integration with IGR #1095
+321
−58
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import json | ||
| import math | ||
|
|
||
| h = 0.2 | ||
|
|
||
| # Radius as a percentage of height (h) | ||
| rc = 0.2 | ||
|
|
||
| gam_a = 1.4 | ||
| p0 = 1 | ||
| rho0 = 1.4 | ||
| c0 = math.sqrt(gam_a * p0 / rho0) | ||
| v0 = 3 * c0 | ||
| mu = rho0 * v0 * h / 2e5 | ||
|
|
||
| # Configuring case dictionary | ||
| print( | ||
| json.dumps( | ||
| { | ||
| # Logistics | ||
| "run_time_info": "T", | ||
| "x_domain%beg": 0, | ||
| "x_domain%end": 15 * h, | ||
| "y_domain%beg": 0, | ||
| "y_domain%end": 5 * h, | ||
| "cyl_coord": "F", | ||
| "m": 1499, | ||
| "n": 499, | ||
| "p": 0, | ||
| "cfl_adap_dt": "T", | ||
| "cfl_target": 0.6, | ||
| "n_start": 0, | ||
| "t_save": 0.04, | ||
| "t_stop": 4, | ||
| # Simulation Algorithm Parameters | ||
| "num_patches": 1, | ||
| "model_eqns": 2, | ||
| "alt_soundspeed": "F", | ||
| "num_fluids": 1, | ||
| "mpp_lim": "F", | ||
| "mixture_err": "F", | ||
| "time_stepper": 3, | ||
| "igr": "T", | ||
| "igr_pres_lim": "T", | ||
| "igr_order": 3, | ||
| "igr_iter_solver": 1, | ||
| "num_igr_iters": 5, | ||
| "num_igr_warm_start_iters": 50, | ||
| "bc_x%beg": -3, | ||
| "bc_x%end": -3, | ||
| "bc_y%beg": -2, | ||
| "bc_y%end": -2, | ||
| "ib": "T", | ||
| "num_ibs": 3, | ||
| # Formatted Database Files Structure Parameters | ||
| "format": 1, | ||
| "precision": 2, | ||
| "prim_vars_wrt": "T", | ||
| "parallel_io": "T", | ||
| # Patch 1 Background | ||
| "patch_icpp(1)%geometry": 3, | ||
| "patch_icpp(1)%x_centroid": 7.5 * h, | ||
| "patch_icpp(1)%y_centroid": 2.5 * h, | ||
| "patch_icpp(1)%length_x": 15 * h, | ||
| "patch_icpp(1)%length_y": 5 * h, | ||
| "patch_icpp(1)%vel(1)": v0, | ||
| "patch_icpp(1)%vel(2)": 0.0, | ||
| "patch_icpp(1)%pres": p0, | ||
| "patch_icpp(1)%alpha_rho(1)": rho0, | ||
| "patch_icpp(1)%alpha(1)": 1.0, | ||
| # Patch: No slip rectangle with rouded corner | ||
| "patch_ib(1)%geometry": 3, | ||
| "patch_ib(1)%x_centroid": 11.5 * h + rc*h, | ||
| "patch_ib(1)%y_centroid": 0 * h, | ||
| "patch_ib(1)%length_x": 17 * h, | ||
| "patch_ib(1)%length_y": 2 * h, | ||
| "patch_ib(1)%slip": "T", | ||
|
Comment on lines
+71
to
+77
Contributor
There was a problem hiding this comment. Fix typo and resolve slip/no-slip contradiction. The comment on Line 71 contains issues:
Please clarify whether the immersed boundaries should use slip or no-slip conditions and update either the comment or the configuration accordingly. 🤖 Prompt for AI Agents |
||
| "patch_ib(2)%geometry": 3, | ||
| "patch_ib(2)%x_centroid": (3 + rc/2)*h, | ||
| "patch_ib(2)%y_centroid": -rc * h, | ||
| "patch_ib(2)%length_x": rc*h, | ||
| "patch_ib(2)%length_y": 2 * h, | ||
| "patch_ib(2)%slip": "T", | ||
|
Comment on lines
+78
to
+83
Contributor
There was a problem hiding this comment. Immersed boundary patch extends below domain boundary. The second immersed boundary patch (
The patch extends 0.24 units below the domain. If this is intentional (e.g., to model the bottom wall of the step), please confirm. Otherwise, adjust the geometry. 🤖 Prompt for AI Agents |
||
| "patch_ib(3)%geometry": 2, | ||
| "patch_ib(3)%x_centroid": (3 + rc)*h, | ||
| "patch_ib(3)%y_centroid": (1 - rc)*h, | ||
| "patch_ib(3)%radius" : rc*h, | ||
| "patch_ib(3)%slip": "T", | ||
| # Fluids Physical Parameters | ||
| "fluid_pp(1)%gamma": 1.0 / (gam_a - 1.0), | ||
| "fluid_pp(1)%pi_inf": 0.0, | ||
| "viscous": "T", | ||
| "fluid_pp(1)%Re(1)": 1 / mu, | ||
| }, | ||
| indent=4, | ||
| ) | ||
| ) | ||
|
Comment on lines
+1
to
+97
Contributor
There was a problem hiding this comment. Address the formatting error flagged by the pipeline. The MFC formatting step failed during the CI pipeline. Please run the project's formatting tool locally to identify and fix the formatting issues in this file. 🧰 Tools🪛 GitHub Actions: Pretty[error] 1-1: mfc formatting step exited with code 1. Formatting process encountered an error after applying patches to case.py. 🤖 Prompt for AI Agents |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Immersed boundary patch extends beyond domain boundary.
The first immersed boundary patch (
patch_ib(1)) appears to extend beyond the computational domain:11.5 * h + rc * h = 2.3417 * h = 3.42.34 + 3.4/2 = 4.04x_domain%end = 15 * h = 3.0The patch extends approximately 1.04 units beyond the domain boundary. Please verify this geometry is correct for the forward-facing step configuration.
🤖 Prompt for AI Agents