-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(installer/windows): add wix installer #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
14ce5ed to
f20af0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
==========================================
- Coverage 15.50% 15.43% -0.07%
==========================================
Files 94 94
Lines 19089 19089
Branches 8801 8801
==========================================
- Hits 2960 2947 -13
+ Misses 14346 14327 -19
- Partials 1783 1815 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportChanges will increase total bundle size by 119 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
|
9e4b955 to
6ef5e6e
Compare
|
|
The latest NSIS version now runs properly on ARM64 systems, so we can stick with NSIS if we want. WiX does make it easier to support having a single unified installer for both x64 and ARM64 binaries if we want that. |
|
Good to know. I still need to setup a VM to test this out. I think msi would still be nice to use, especially for anyone installing Sunshine with a script as it supports more CLI options. I discovered in a recent change that I couldn't even get the output of the installer scripts to a log file with NSIS. Do you know the process for unifying the installer? That would be pretty nice. |
c3efb02 to
07c0044
Compare
|
07c0044 to
805e270
Compare
|
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
805e270 to
0f10c15
Compare
|



Description
This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.
This is a requirement for having an ARM64 installer for #3905 or #3369
TODO:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist