use std::optional<std::string> over std::string*#20
Open
ronag wants to merge 1 commit intoLevel:mainfrom
Open
Conversation
ronag
commented
Apr 3, 2022
ronag
force-pushed
the
optional
branch
2 times, most recently
from
45995a3 to
f59bffd
Compare
This was referenced Apr 9, 2022
Closed
ronag
force-pushed
the
optional
branch
2 times, most recently
from
6aecd45 to
ddb6cf4
Compare
Contributor
Author
|
@vweevers this won't work as prebuildify-cross will fail for std::optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.