Open
Conversation
reneemeyer
reviewed
Nov 6, 2018
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Good job, just some function organization changes. Overall though, great methods
|
|
||
| function movePiece(startStack, endStack) { | ||
| if (startStack === 'a' && endStack === 'b') { | ||
| let mover = stacks.a.pop(); |
| // Your code here | ||
|
|
||
| function movePiece(startStack, endStack) { | ||
| if (startStack === 'a' && endStack === 'b') { |
There was a problem hiding this comment.
for every stack and letter, you're checking if the stack is a,b, or c, twice, that's a lot of repetition that you can condense.
| let mover = stacks.a.pop(); | ||
| stacks.b.push(mover); | ||
| } else if (startStack === 'a' && endStack === 'c') { | ||
| let mover = stacks.a.pop(); |
| let mover = stacks.a.pop(); | ||
| stacks.c.push(mover); | ||
| } else if (startStack === 'b' && endStack === 'a') { | ||
| let mover = stacks.b.pop(); |
| let mover = stacks.b.pop(); | ||
| stacks.a.push(mover); | ||
| } else if (startStack === 'b' && endStack === 'c') { | ||
| let mover = stacks.b.pop(); |
| let mover = stacks.b.pop(); | ||
| stacks.c.push(mover); | ||
| } else if (startStack === 'c' && endStack === 'a') { | ||
| let mover = stacks.c.pop(); |
| let mover = stacks.c.pop(); | ||
| stacks.a.push(mover); | ||
| } else { | ||
| let mover = stacks.c.pop(); |
| function isLegal(start, end) { | ||
| const startStack = stacks[start]; | ||
| const endStack = stacks[end]; | ||
| if (startStack.length === 0) { |
There was a problem hiding this comment.
anytime that you see that you're returning true or false, return the evaluation
|
|
||
| function checkForWin() { | ||
| // Your code here | ||
| if (stacks.b.length === 4 || stacks.c.length === 4) { |
There was a problem hiding this comment.
anytime that you see that you're returning true or false, return the evaluation
| function towersOfHanoi(startStack, endStack) { | ||
| // Your code here | ||
|
|
||
| movePiece(startStack, endStack); |
There was a problem hiding this comment.
you should only move the piece if your function is legal, and you should only check for win if your function is legal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3