feat: Add conversation depth analyzer for message tree metrics#3775
Closed
GitHoobar wants to merge 1 commit intoLAION-AI:mainfrom
Closed
feat: Add conversation depth analyzer for message tree metrics#3775GitHoobar wants to merge 1 commit intoLAION-AI:mainfrom
GitHoobar wants to merge 1 commit intoLAION-AI:mainfrom
Conversation
This feature adds the ability to analyze conversation tree depth metrics: - New DepthAnalysis schema for storing analysis results - calculate_tree_depth function for traversing and measuring tree depths - analyze_conversation_depth for single tree analysis - get_depth_summary for batch analysis across multiple trees This helps understand conversation patterns and tree structure in the dataset.
GitHoobar
requested review from
andreaskoepf,
olliestanley and
yk
as code owners
|
❌ pre-commit failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1 (Type Mismatch): schemas.py defines max_depth: int but traversal.py returns it as float — will cause Pydantic validation error.
Bug 2 (Wrong Key Name): traversal.py returns "maximum_depth" but analytics.py accesses "max_depth" — will cause KeyError at runtime.
Bug 3 (Logic Error): analytics.py calculates average depth by dividing sum(leaf_depths) / total_messages instead of / len(leaf_depths) — produces mathematically incorrect results.