Fix misleading _time_secs column name to _time_min#120
Open
Conversation
The aggregated behavior time column was named `_time_secs` but the formula computes `proportion_of_behavior * bin_size * 5`, which yields a value in minutes (e.g. bin_size=4 produces a 20-minute window scaled by the proportion of time spent in the behavior). Rename to `_time_min` in both the Python and R implementations to accurately reflect the unit. Breaking change: downstream consumers of the output CSV that reference columns like `bin_sum_20.grooming_time_secs` must update to `bin_sum_20.grooming_time_min`. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_time_secsto_time_minin both the Python (behavior_summaries.py) and R (behavior_summaries.R) implementations.proportion_of_behavior * bin_size * 5produces a value in minutes (e.g.bin_size=4yields a 20-minute window scaled by the behavior proportion), but the column was labeled_time_secs, which is incorrect and misleading for downstream consumers.Details
Files changed:
support_code/behavior_summaries.py— column renamed frombin_sum_{n}.{behavior}_time_secstobin_sum_{n}.{behavior}_time_minsupport_code/behavior_summaries.R— column renamed frombin_avg_{n}.{behavior}_time_secstobin_avg_{n}.{behavior}_time_minBreaking change: Any downstream notebooks, scripts, or dashboards that reference columns like
bin_sum_20.grooming_time_secsmust update tobin_sum_20.grooming_time_min.Test plan
_time_secscolumn nameMade with Cursor