Trim dependencies #341
Merged
Trim dependencies #341
+28
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
commented
Feb 6, 2026
Comment on lines
+55
to
+57
| "django-minio-storage", | ||
| "django-resonant-utils[minio_storage]", | ||
| "django-s3-file-field[minio]", |
Member
Author
There was a problem hiding this comment.
This MinIO stuff isn't required for production usage on Heroku nor "nabat".
It is required for production usage on the Kitware-internal deployment, but unless it's getting installed with uv sync --no-dev (which Heroku does do), these development dependencies will actually be installed there already.
Deploying bats-ai with
|
| Latest commit: |
22a3028
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://283abcb3.bats-ai.pages.dev |
| Branch Preview URL: | https://trim-deps.bats-ai.pages.dev |
brianhelba
commented
Feb 6, 2026
| "django-cors-headers", | ||
| "django-environ", | ||
| "django-extensions", | ||
| "django-filter", |
Member
Author
There was a problem hiding this comment.
We're not using django-filter at all.
brianhelba
commented
Feb 6, 2026
| "django-resonant-settings[allauth,celery]", | ||
| "django-resonant-utils", | ||
| "django-s3-file-field[s3, minio]", | ||
| "django-resonant-utils[allauth,s3_storage]", |
Member
Author
There was a problem hiding this comment.
These extras should have been included, based on the Resonant cookiecutter. However, this is just keeping versions in sync, not adding anything new.
naglepuff
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.