Merge builderror and buildfailure tables #3441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDash previously used the `builderror` table to store warnings and errors collected via log scraping, and a separate `buildfailure` table to store more detailed warning and error information collected via launchers. While convenient in some cases, having two tables which essentially store the same information requires near-duplicate code throughout the codebase and is very confusing for developers. This commit combines the two tables into a single `builderrors` table and creates `builderror` and `buildfailure` updateable views to remain backwards compatible with existing code. This commit also adds a new `buildErrors` GraphQL field, and deprecates the now-unnecessary `basicErrors` and `basicWarnings` fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash previously used the
builderrortable to store warnings and errors collected via log scraping, and a separatebuildfailuretable to store more detailed warning and error information collected via launchers. While convenient in some cases, having two tables which essentially store the same information requires near-duplicate code throughout the codebase and is very confusing for developers. This commit combines the two tables into a singlebuilderrorstable and createsbuilderrorandbuildfailureupdateable views to remain backwards compatible with existing code. This commit also adds a newbuildErrorsGraphQL field, and deprecates the now-unnecessarybasicErrorsandbasicWarningsfields.