Add updateProject GraphQL mutation
#3438
Conversation
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Most things look and respond great to the mutation running in GraphQL Explorer. My only question is:
Should we allow name in the mutation? If they had access to the settings page for the project, they wouldn't be able to change the name. It is validating properly for name collisions still so they can't collide.
|
@josephsnyder Based on the feedback we got last year when projects wanted to change names due to the case-insensitivity change with the MySQL->Postgres transition, I figured that it's an important thing to have. I wouldn't be opposed to disallowing name changes if you have a good argument for that though. The tests for name changes are here. |
I wouldn't say its a good argument, just noticing it's something we don't currently allow. The case-insensitivity makes sense. Thanks @williamjallen |
This commit adds an `updateProject` mutation which will form the basis for the overhaul of the project settings page. Note that our infrastructure doesn't support multi-part GraphQL requests yet, so I plan to create a separate dedicated route for project logo uploads, outside the GraphQL API.
williamjallen
force-pushed
the
update-project-mutation
branch
from
0075370 to
b9174f0
Compare
The `updateProject` mutation added in Kitware#3438 currently rejects requests with the name field set to the project's current name. It's much more convenient to be able to submit all fields, regardless of whether they were changed or not. This PR allows the mutation to be called with the project's current name.
The `updateProject` mutation added in #3438 currently rejects requests with the name field set to the project's current name. It's much more convenient to be able to submit all fields, regardless of whether they were changed or not. This PR allows the mutation to be called with the project's current name.
2 participants
This commit adds an
updateProjectmutation which will form the basis for the overhaul of the project settings page. Note that our infrastructure doesn't support multi-part GraphQL requests yet, so I plan to create a separate dedicated route for project logo uploads, outside the GraphQL API.