#9186 Clean-up for fix: camera becomes perspective fix cleanup #9469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermine if file watcher event was caused by us or externally
…he writeFile call
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewvarga
commented
Dec 26, 2025
| // which would be evident if we already have matching code there. | ||
| if (!isCodeTheSame(code, kclManager.codeSignal.value)) { | ||
| const lastWrittenCode = kclManager.lastWrite?.code | ||
| if (!lastWrittenCode || !isCodeTheSame(lastWrittenCode, code)) { |
Contributor
Author
There was a problem hiding this comment.
This is the actual fix instead of using stat.mtimeMs
andrewvarga
commented
Dec 26, 2025
|
|
||
| toast('Reloading file from disk') | ||
| // If we can use emojis this looks nice: | ||
| // toast('Reloading file from disk', { icon: '📁' }) |
Contributor
Author
There was a problem hiding this comment.
This looks nice I just didn't want to start adding emojis to the codebase since we don't have any yet.
andrewvarga
commented
Dec 26, 2025
| code: this.code ?? '', | ||
| time: Date.now(), | ||
| } | ||
| this.writeCausedByAppCheckedInFileTreeFileSystemWatcher = true |
Contributor
Author
There was a problem hiding this comment.
I moved this down right before the actual write as I think that's technically the more correct way to do it.
jtran
approved these changes
Dec 29, 2025
lee-at-zoo-corp
deleted the
andrewvarga/9186/camera-becomes-perspective-fix-cleanup
branch
franknoirot
added a commit
that referenced
this pull request
Jan 2, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 5, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 6, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 6, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 7, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 7, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 7, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 7, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 8, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 8, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 9, 2026
franknoirot
added a commit
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #9186.
The previous fix used the current file's last modified date and compared it to when ZDS last updated the file to determine if changes on the file were caused by us or externally.
This alternative fix fixes the original issue by comparing the last written code to the file's content, instead of the current
kclManager.codewhich was the main cause for the original bug.There are 2 additional refinements: