Skip to content

Default backface #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamaan476 merged 9 commits into from
Jan 6, 2026
Merged

Default backface #9290

benjamaan476 merged 9 commits into from
Jan 6, 2026

Conversation

@benjamaan476
Copy link
Contributor

@benjamaan476 benjamaan476 commented Dec 10, 2025

Introduce a DEFAULT_BACKFACE_COLOR that is currently hard coded and sent to the engine on connection. This can be pulled in from user space with a follow-up effort

@benjamaan476 benjamaan476 requested review from a team as code owners December 10, 2025 13:40
@vercel
Copy link

vercel bot commented Dec 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
modeling-app Ready Ready Preview, Comment Jan 6, 2026 1:13am

@benjamaan476 benjamaan476 self-assigned this Dec 10, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9290 will not alter performance

Comparing ben/default_backface (018eebe) with main (8260030)1

Summary

✅ 152 untouched
⏩ 92 skipped2

Footnotes

  1. No successful run was found on main (3a61d99) during the generation of this report, so 8260030 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

franknoirot
franknoirot reviewed Dec 10, 2025
View reviewed changes
@jacebrowning jacebrowning marked this pull request as draft December 11, 2025 18:49
@benjamaan476 benjamaan476 marked this pull request as ready for review January 5, 2026 14:51
franknoirot
franknoirot approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app works as expected in the Vercel preview so nothing seems broken by this. I don't think I can verify the backface color yet but lmk if I'm mistaken and we actually support a bit of surface modeling I can use to test it.

rust/Cargo.toml

#Example: how to point modeling-app at a different repo (e.g. a branch or a local clone)
# [patch.crates-io]
# kcl-ezpz = { path = "../../ezpz/kcl-ezpz" }
Copy link
Contributor

@franknoirot franknoirot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not have intended to delete this line

@benjamaan476
Copy link
Contributor Author

benjamaan476 commented Jan 6, 2026

The engine already supports backface colour and surface modeling @franknoirot. If you call an extrude and add the arg bodyType = "surface" to it you'll get a surface

@benjamaan476 benjamaan476 merged commit 1fa1204 into main Jan 6, 2026
102 of 104 checks passed
@benjamaan476 benjamaan476 deleted the ben/default_backface branch January 6, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franknoirot franknoirot franknoirot approved these changes

Assignees

@benjamaan476 benjamaan476

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjamaan476 @franknoirot