Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

This PR replaced the spinner with the Gutenberg ProgressBar component, resulting in errors when clicking the refresh button within a block in WordPress < 6.3.

Screenshot 2026-01-07 at 12 56 09

This PR resolves by using a spinner when the ProgressBar component is unavailable:

WordPress 6.2.8:
Screenshot 2026-01-07 at 12 10 34

WordPress 6.9:
Screenshot 2026-01-07 at 12 10 39

The refresh text within the button is also fixed:

Before:
Screenshot 2026-01-07 at 12 55 50

After:
Screenshot 2026-01-07 at 12 58 18

This PR also:

  • runs backward compat. tests for blocks against WordPress 6.2.8, PHP 8.1
  • uses a more generic selector when checking a block is refreshing
  • uses a more generic selector when tests click the insert block button, to support WordPress 6.2.8 and higher

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Jan 7, 2026
@n7studios n7studios added the bug label Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground

@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team January 7, 2026 10:11
@n7studios n7studios marked this pull request as ready for review January 7, 2026 10:11
Copy link
Contributor

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to figure out if there was a way to reuse some of this configuration from tests.yml, but it for now I don't think the juice is worth the squeeze since the reusable workflows really is more targeted to a workflow that can be parameterized with different env vars.

@n7studios n7studios merged commit 81a4025 into fix-uncode-tests Jan 8, 2026
225 of 233 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants