Skip to content

Align docu and source of 03_physical_device_selection #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asuessenbach wants to merge 2 commits into
base: main
Choose a base branch
from
+1,594 −1,466
Open

Align docu and source of 03_physical_device_selection #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3cace
Adjust docu and source of 03_physical_device_selection
asuessenbach Feb 18, 2026
41e3dea
change from VK_API_VERSION_1_3 to vk::ApiVersion13
asuessenbach Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 41 additions & 38 deletions attachments/03_physical_device_selection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,44 +149,47 @@ class HelloTriangleApplication
debugMessenger = instance.createDebugUtilsMessengerEXT(debugUtilsMessengerCreateInfoEXT);
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> devices = instance.enumeratePhysicalDevices();
const auto devIter = std::ranges::find_if(
devices,
[&](auto const &device) {
// Check if the device supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = device.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = device.getQueueFamilyProperties();
bool supportsGraphics =
std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });

// Check if all required device extensions are available
auto availableDeviceExtensions = device.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of(requiredDeviceExtension,
[&availableDeviceExtensions](auto const &requiredDeviceExtension) {
return std::ranges::any_of(availableDeviceExtensions,
[requiredDeviceExtension](auto const &availableDeviceExtension) { return strcmp(availableDeviceExtension.extensionName, requiredDeviceExtension) == 0; });
});

auto features = device.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
});
if (devIter != devices.end())
{
physicalDevice = *devIter;
}
else
{
throw std::runtime_error("failed to find a suitable GPU!");
}
}
bool isDeviceSuitable( vk::raii::PhysicalDevice const & physicalDevice )
{
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= vk::ApiVersion13;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of( queueFamilies, []( auto const & qfp ) { return !!( qfp.queueFlags & vk::QueueFlagBits::eGraphics ); } );

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of( requiredDeviceExtension,
[&availableDeviceExtensions]( auto const & requiredDeviceExtension )
{
return std::ranges::any_of( availableDeviceExtensions,
[requiredDeviceExtension]( auto const & availableDeviceExtension )
{ return strcmp( availableDeviceExtension.extensionName, requiredDeviceExtension ) == 0; } );
} );

// Check if the physicalDevice supports the required features
auto features =
physicalDevice
.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> physicalDevices = instance.enumeratePhysicalDevices();
auto const devIter = std::ranges::find_if( physicalDevices, [&]( auto const & physicalDevice ) { return isDeviceSuitable( physicalDevice ); } );
if ( devIter == physicalDevices.end() )
{
throw std::runtime_error( "failed to find a suitable GPU!" );
}
physicalDevice = *devIter;
}

std::vector<const char *> getRequiredInstanceExtensions()
{
Expand Down
79 changes: 41 additions & 38 deletions attachments/04_logical_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,44 +154,47 @@ class HelloTriangleApplication
debugMessenger = instance.createDebugUtilsMessengerEXT(debugUtilsMessengerCreateInfoEXT);
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> devices = instance.enumeratePhysicalDevices();
const auto devIter = std::ranges::find_if(
devices,
[&](auto const &device) {
// Check if the device supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = device.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = device.getQueueFamilyProperties();
bool supportsGraphics =
std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });

// Check if all required device extensions are available
auto availableDeviceExtensions = device.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of(requiredDeviceExtension,
[&availableDeviceExtensions](auto const &requiredDeviceExtension) {
return std::ranges::any_of(availableDeviceExtensions,
[requiredDeviceExtension](auto const &availableDeviceExtension) { return strcmp(availableDeviceExtension.extensionName, requiredDeviceExtension) == 0; });
});

auto features = device.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
});
if (devIter != devices.end())
{
physicalDevice = *devIter;
}
else
{
throw std::runtime_error("failed to find a suitable GPU!");
}
}
bool isDeviceSuitable( vk::raii::PhysicalDevice const & physicalDevice )
{
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of( queueFamilies, []( auto const & qfp ) { return !!( qfp.queueFlags & vk::QueueFlagBits::eGraphics ); } );

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of( requiredDeviceExtension,
[&availableDeviceExtensions]( auto const & requiredDeviceExtension )
{
return std::ranges::any_of( availableDeviceExtensions,
[requiredDeviceExtension]( auto const & availableDeviceExtension )
{ return strcmp( availableDeviceExtension.extensionName, requiredDeviceExtension ) == 0; } );
} );

// Check if the physicalDevice supports the required features
auto features =
physicalDevice
.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> physicalDevices = instance.enumeratePhysicalDevices();
auto const devIter = std::ranges::find_if( physicalDevices, [&]( auto const & physicalDevice ) { return isDeviceSuitable( physicalDevice ); } );
if ( devIter == physicalDevices.end() )
{
throw std::runtime_error( "failed to find a suitable GPU!" );
}
physicalDevice = *devIter;
}

void createLogicalDevice()
{
Expand Down
79 changes: 41 additions & 38 deletions attachments/05_window_surface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,44 +162,47 @@ class HelloTriangleApplication
surface = vk::raii::SurfaceKHR(instance, _surface);
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> devices = instance.enumeratePhysicalDevices();
const auto devIter = std::ranges::find_if(
devices,
[&](auto const &device) {
// Check if the device supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = device.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = device.getQueueFamilyProperties();
bool supportsGraphics =
std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });

// Check if all required device extensions are available
auto availableDeviceExtensions = device.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of(requiredDeviceExtension,
[&availableDeviceExtensions](auto const &requiredDeviceExtension) {
return std::ranges::any_of(availableDeviceExtensions,
[requiredDeviceExtension](auto const &availableDeviceExtension) { return strcmp(availableDeviceExtension.extensionName, requiredDeviceExtension) == 0; });
});

auto features = device.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
});
if (devIter != devices.end())
{
physicalDevice = *devIter;
}
else
{
throw std::runtime_error("failed to find a suitable GPU!");
}
}
bool isDeviceSuitable( vk::raii::PhysicalDevice const & physicalDevice )
{
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of( queueFamilies, []( auto const & qfp ) { return !!( qfp.queueFlags & vk::QueueFlagBits::eGraphics ); } );

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of( requiredDeviceExtension,
[&availableDeviceExtensions]( auto const & requiredDeviceExtension )
{
return std::ranges::any_of( availableDeviceExtensions,
[requiredDeviceExtension]( auto const & availableDeviceExtension )
{ return strcmp( availableDeviceExtension.extensionName, requiredDeviceExtension ) == 0; } );
} );

// Check if the physicalDevice supports the required features
auto features =
physicalDevice
.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> physicalDevices = instance.enumeratePhysicalDevices();
auto const devIter = std::ranges::find_if( physicalDevices, [&]( auto const & physicalDevice ) { return isDeviceSuitable( physicalDevice ); } );
if ( devIter == physicalDevices.end() )
{
throw std::runtime_error( "failed to find a suitable GPU!" );
}
physicalDevice = *devIter;
}

void createLogicalDevice()
{
Expand Down
79 changes: 41 additions & 38 deletions attachments/06_swap_chain_creation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,44 +170,47 @@ class HelloTriangleApplication
surface = vk::raii::SurfaceKHR(instance, _surface);
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> devices = instance.enumeratePhysicalDevices();
const auto devIter = std::ranges::find_if(
devices,
[&](auto const &device) {
// Check if the device supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = device.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = device.getQueueFamilyProperties();
bool supportsGraphics =
std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });

// Check if all required device extensions are available
auto availableDeviceExtensions = device.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of(requiredDeviceExtension,
[&availableDeviceExtensions](auto const &requiredDeviceExtension) {
return std::ranges::any_of(availableDeviceExtensions,
[requiredDeviceExtension](auto const &availableDeviceExtension) { return strcmp(availableDeviceExtension.extensionName, requiredDeviceExtension) == 0; });
});

auto features = device.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
});
if (devIter != devices.end())
{
physicalDevice = *devIter;
}
else
{
throw std::runtime_error("failed to find a suitable GPU!");
}
}
bool isDeviceSuitable( vk::raii::PhysicalDevice const & physicalDevice )
{
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of( queueFamilies, []( auto const & qfp ) { return !!( qfp.queueFlags & vk::QueueFlagBits::eGraphics ); } );

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
bool supportsAllRequiredExtensions =
std::ranges::all_of( requiredDeviceExtension,
[&availableDeviceExtensions]( auto const & requiredDeviceExtension )
{
return std::ranges::any_of( availableDeviceExtensions,
[requiredDeviceExtension]( auto const & availableDeviceExtension )
{ return strcmp( availableDeviceExtension.extensionName, requiredDeviceExtension ) == 0; } );
} );

// Check if the physicalDevice supports the required features
auto features =
physicalDevice
.template getFeatures2<vk::PhysicalDeviceFeatures2, vk::PhysicalDeviceVulkan13Features, vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>();
bool supportsRequiredFeatures = features.template get<vk::PhysicalDeviceVulkan13Features>().dynamicRendering &&
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
{
std::vector<vk::raii::PhysicalDevice> physicalDevices = instance.enumeratePhysicalDevices();
auto const devIter = std::ranges::find_if( physicalDevices, [&]( auto const & physicalDevice ) { return isDeviceSuitable( physicalDevice ); } );
if ( devIter == physicalDevices.end() )
{
throw std::runtime_error( "failed to find a suitable GPU!" );
}
physicalDevice = *devIter;
}

void createLogicalDevice()
{
Expand Down
Loading
Loading