This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Adding allowMultiple to the descriptor attribute#607
Open
fat-rooster wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Open
Adding allowMultiple to the descriptor attribute#607fat-rooster wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
fat-rooster wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little quality of life change for modders to make our code a little cleaner. The allowMultiple=false restriction to the myEntityComponentDescriptor attribute meant we needed to build duplicate classes for each builder we wanted to add logic to, rather than adding the same logic to multiple builders.
See this mod for the motivating example. (Ignore the lack of nuance to it. I'm just referring to the duplicated classes)
https://steamcommunity.com/sharedfiles/filedetails/?id=2288648839
No functionality is lost or modified with this change. The code already retrieves the attribute as an array. The null check would require a bug in system.reflection to fail, so can probably be omitted too. Thanks for your time.